Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple reproducibility test command. #13689

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add a simple reproducibility test command. #13689

merged 1 commit into from
Oct 1, 2024

Conversation

jpakkane
Copy link
Member

No description provided.

@jpakkane jpakkane force-pushed the reprotest branch 3 times, most recently from 9ba04e5 to d13673b Compare September 19, 2024 08:31
Copy link

@fortysixandtwo fortysixandtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool, I just gave it a little spin.

Currently ccache in my PATH is not detected in which case it should also abort.

🚀

## Simple tool to test build reproducibility

Meson now ships with a command for testing whether your project can be
[built reprodicibly](https://reproducible-builds.org/). It can be used

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: s/reprodicibly/reproducibly

Comment on lines +15 to +16
# Note: when adding arguments, please also add them to the completion
# scripts in $MESONSRC/data/shell-completions/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have I missed these?

docs/markdown/Commands.md Outdated Show resolved Hide resolved
mesonbuild/scripts/reprotest.py Outdated Show resolved Hide resolved
mesonbuild/scripts/reprotest.py Show resolved Hide resolved
mesonbuild/scripts/reprotest.py Show resolved Hide resolved
mesonbuild/scripts/reprotest.py Outdated Show resolved Hide resolved
@jpakkane
Copy link
Member Author

FWICT all warnings are about too many positional arguments, which is unrelated to this change.

@dcbaker
Copy link
Member

dcbaker commented Sep 21, 2024

@jpakkane, we fixed the "too many positional arguments" thing in the master branch

@jpakkane
Copy link
Member Author

All green after rebase.

@dcbaker
Copy link
Member

dcbaker commented Sep 23, 2024

I'd still like to see the protocol used for typing the arguments instead of Any. I've also thought about this a bit more, and I think it would be good to use at least two different return codes, one for reproducibility errors, and one for generic failures that don't mean that there's a reproducibility error. Something like:
0 - everything is fine
1 - there is a reproducibility error
2 - there was an error, but it was not a reproducibility one (exceptions thrown, subprocess failed to run, etc)

mesonbuild/scripts/reprotest.py Outdated Show resolved Hide resolved
@jpakkane jpakkane force-pushed the reprotest branch 8 times, most recently from 33d66fa to fc43ee6 Compare September 28, 2024 20:24
@jpakkane jpakkane merged commit 9ce6076 into master Oct 1, 2024
38 checks passed
@jpakkane jpakkane deleted the reprotest branch October 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants