Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix full dependencies that should be order only in ninja backend #13377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix full dependencies that should be order only in ninja backend #13377

wants to merge 4 commits into from
+57 −25

Commits on Oct 1, 2024

  1. backends/ninja: annotate the generate_single_compile function

    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    908a172 View commit details
    Browse the repository at this point in the history

  2. backends/ninja: rename the add_header_deps method 

    header dependency are usually order-only, but this actually provides a
full dependency.
    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    80b5f31 View commit details
    Browse the repository at this point in the history

  3. backends/ninja: refactor duplicated code into a helper

    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    32474c0 View commit details
    Browse the repository at this point in the history

  4. backends/ninja: fix dependencies added as full but should be order-only 

    Due to the confusing naming of the parameters, a number of arguments
were incorrectly added as full dependencies when they should be order
only.
    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c6963bb View commit details
    Browse the repository at this point in the history