rewriter: don't output target info to stderr #12255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to fix the test failures too |
benoit-pierre
force-pushed
the
pr/fix_rewrite_target_info
branch
from
c8c8049
to
6325551
Compare
benoit-pierre
force-pushed
the
pr/fix_rewrite_target_info
branch
from
6325551
to
6c398ba
Compare
|
Any reason you closed this? |
|
It's been more than a year, what's the point? |
|
@benoit-pierre. Yeah, we really struggle with stuff falling through the cracks. This looks fine to me, actually. |
dcbaker
approved these changes
Sep 20, 2024
|
Unfortunately (and even the core maintainers have to do this too), we just sometimes have to ping the MR or matrix and ask for review of things. I'll merge this as long as CI is green when it's done. |
|
@benoit-pierre A rebase may be needed to get the linters happy |
Send the info to stdout, where it belongs.
benoit-pierre
force-pushed
the
pr/fix_rewrite_target_info
branch
from
6c398ba
to
8b6122c
Compare
|
Master is failing the lint job too, I guess due to the newly released 3.3.0 version of pylint. |
|
Fix for pylint: #13695. |
|
that's merged, thanks for doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the info to stdout, where it belongs.