Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project deps to latest except Tailwind #380

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

danditomaso
Copy link
Collaborator

  • Updated all project dependencies while keeping Tailwind at current version due to breaking changes in 4.x
  • Replaced @emeraldpay/hashicon lib with custom React component alternative due to React 19 compatibility issue with Hashicon

@danditomaso
Copy link
Collaborator Author

image

@KomelT
Copy link
Contributor

KomelT commented Jan 24, 2025

I looked a little and saw that dependency @buf/meshtastic_protobufs.bufbuild_es and @radix-ui/react-accordion could probably be deleted. They look unused.

Tool npm-check saw also these dependencies as unused:

class-transformer
vite-plugin-node-polyfills
autoprefixer
postcss
tar
tslib
typescript (this is probably a mistake)

@danditomaso
Copy link
Collaborator Author

danditomaso commented Jan 25, 2025

Thanks for checking on that. Yes I came to a similar conclusion and after further investigation I found that Tslib is required as a peer dep by the class-validator package. Typescript should become a dev dependency , Autoprefixer and Postcss are required for Tailwind to run properly and should be moved to dev dependencies.

@danditomaso
Copy link
Collaborator Author

Tar is used as part of an package JSON build script, so should remain a dependency and since it isn't referenced in the code base it won't be bundled

@danditomaso
Copy link
Collaborator Author

@KomelT I could swear I had tried removing Tslib in the past and it had broken something, I tested removing Tslib today and after several restarts of the app, reloading all node_modules, and testing a full build everything is still running.

Nice catch on some of those libs, I just pushed a new commit which shifts a couple of tailwind libs into dev dependencies, and removed a couple of other dev dependencies that were unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants