-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project deps to latest except Tailwind #380
base: master
Are you sure you want to change the base?
Update project deps to latest except Tailwind #380
Conversation
danditomaso
commented
Jan 23, 2025
- Updated all project dependencies while keeping Tailwind at current version due to breaking changes in 4.x
- Replaced @emeraldpay/hashicon lib with custom React component alternative due to React 19 compatibility issue with Hashicon
ed98f69
to
2da77b0
Compare
I looked a little and saw that dependency @buf/meshtastic_protobufs.bufbuild_es and @radix-ui/react-accordion could probably be deleted. They look unused. Tool npm-check saw also these dependencies as unused:
|
Thanks for checking on that. Yes I came to a similar conclusion and after further investigation I found that |
Tar is used as part of an package JSON build script, so should remain a dependency and since it isn't referenced in the code base it won't be bundled |
@KomelT I could swear I had tried removing Tslib in the past and it had broken something, I tested removing Tslib today and after several restarts of the app, reloading all node_modules, and testing a full build everything is still running. Nice catch on some of those libs, I just pushed a new commit which shifts a couple of tailwind libs into dev dependencies, and removed a couple of other dev dependencies that were unneeded. |