Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added primary and secondary refs for logs #78

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Jul 9, 2021

Signed-off-by: dhruv0000 patel.4@iitj.ac.in

Description
MeshSync will now pass the pod and container name, along with the log data to the NATS client.

This PR fixes #100 [meshery-extensions]

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@welcome
Copy link

welcome bot commented Jul 9, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@dhruv0000 dhruv0000 requested review from kumarabd and leecalcote July 9, 2021 00:07
@leecalcote leecalcote merged commit e668138 into meshery:master Jul 9, 2021
@welcome
Copy link

welcome bot commented Jul 9, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants