Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return err if dependency.Start() fails in service.Start() #380

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Aug 21, 2018

@ilgooz ilgooz added the bug Something isn't working label Aug 21, 2018
@ilgooz ilgooz requested a review from a team August 21, 2018 16:57
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Bug introduced during the big refactor.

b04bb7f

@NicolasMahe NicolasMahe merged commit 3ecfa9a into dev Aug 22, 2018
@NicolasMahe NicolasMahe deleted the feature/fix-service-start branch August 22, 2018 04:39
ilgooz added a commit that referenced this pull request Aug 22, 2018
ilgooz added a commit that referenced this pull request Aug 22, 2018
NicolasMahe pushed a commit that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants