Skip to content

Commit

Permalink
Remove invalid comparison of va_list and nullptr (facebook#5836)
Browse files Browse the repository at this point in the history
Summary:
The comparison of va_list and nullptr is always False under any arch, and will raise invalid operands of types error in aarch64 env (`error: invalid operands of types ‘va_list {aka __va_list}’ and ‘std::nullptr_t’ to binary ‘operator!=’`).

This patch removes this invalid assert.

Closes: facebook#4277
Pull Request resolved: facebook#5836

Differential Revision: D17532470

fbshipit-source-id: ca98078ecbc6a9416c69de3bd6ffcfa33a0f0185
  • Loading branch information
Yikun authored and facebook-github-bot committed Sep 23, 2019
1 parent 0cb7ea4 commit c3007c8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion java/rocksjni/loggerjnicallback.cc
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ void LoggerJniCallback::Logv(const InfoLogLevel log_level, const char* format,
}

assert(format != nullptr);
assert(ap != nullptr);
const std::unique_ptr<char[]> msg = format_str(format, ap);

// pass msg to java callback handler
Expand Down

0 comments on commit c3007c8

Please sign in to comment.