Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/allow inclusive enddates #872

Merged
merged 19 commits into from
Jul 12, 2019
Merged

Feature/allow inclusive enddates #872

merged 19 commits into from
Jul 12, 2019

Commits on Jul 6, 2019

  1. test(ganttDb.spec): add test case for inclusive end dates

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    123fba5 View commit details
    Browse the repository at this point in the history

  2. test(gantt.spec): add parser test for inclusive end dates

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    402d4bd View commit details
    Browse the repository at this point in the history

  3. fix(ganttDb.js): clear formats and excludes on clear

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    6dce255 View commit details
    Browse the repository at this point in the history

  4. feat(ganttDb.js): add getters for excludes,sections and date format

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    6d20ccc View commit details
    Browse the repository at this point in the history

  5. test(ganttDb.spec): clear function

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    0515375 View commit details
    Browse the repository at this point in the history

  6. test(ganttDB.spec): fix typo

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    5c2d416 View commit details
    Browse the repository at this point in the history

  7. test(ganttDb.spec): flip function design to specify inclusive instead

    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    b5b7148 View commit details
    Browse the repository at this point in the history

  8. feat(ganttDb.js): add 1 day to end dates if inclusive is set to true 

    This will essentially keep all old behavior the same while still allowing users to specify if they want inclusive end dates
    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    63096a5 View commit details
    Browse the repository at this point in the history

  9. fix(ganttDb): change manual end time determination 

    now it just checks if a valid end time was provided and instead of the comparison that went on before.
This needed to be done in order to support manual end dates with inclusive set to true since they don't match anymore as the 'manually' supplied end date is increased by one
    Jason Würtz committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    ee766ec View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. refactor(ganttDb): separate out the inclusive end date toggle

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    660e0f3 View commit details
    Browse the repository at this point in the history

  2. test(ganttDb): update inclusive end date tests

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    0a567a3 View commit details
    Browse the repository at this point in the history

  3. feat(gantt.jison): update parser to accept a inclusive end date arg 

    if a line contains inclusiveEndDates then it will toggle the chart to use inclusive end dates
    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    16f3338 View commit details
    Browse the repository at this point in the history

  4. chore(gantt.js): generate parser from jison

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    cb7d05b View commit details
    Browse the repository at this point in the history

  5. test(gantt.spec): add assertions to check that the parser didn't error

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    1ee4b96 View commit details
    Browse the repository at this point in the history

  6. feat(index.html): add example to display new behavior

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    a671576 View commit details
    Browse the repository at this point in the history

  7. refactor(ganttDb.js): extract durationToDate function 

    codeclimate was complaining about the getEndDate function so I split it up
    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    67bb5ff View commit details
    Browse the repository at this point in the history

  8. test(ganttDb.spec): fix missing initialization for clear test

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    b7c4b66 View commit details
    Browse the repository at this point in the history

  9. chore(ganttDb): export durationToDate so it can be tested

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    047760a View commit details
    Browse the repository at this point in the history

  10. test(ganttDb.spec): add simple tests for the durationToDate fn

    Jason Würtz committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    c6511ed View commit details
    Browse the repository at this point in the history