Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(integrations): fix listing order #5968

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Oct 16, 2024

📑 Summary

  • Quarto is not related to MkDocs.
  • I think Astro and Jekyll should be listed as Document Generation

📏 Design Decisions

Document minor changes only.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 8aa87c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 8aa87c7
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/670fb5005b59fd00092ad63f
😎 Deploy Preview https://deploy-preview-5968--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5968
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5968
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5968
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5968

commit: 8aa87c7

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.64%. Comparing base (742531a) to head (8aa87c7).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5968   +/-   ##
=======================================
  Coverage     4.64%   4.64%           
=======================================
  Files          375     374    -1     
  Lines        51976   51965   -11     
  Branches       587     613   +26     
=======================================
  Hits          2414    2414           
+ Misses       49562   49551   -11     
Flag Coverage Δ
unit 4.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 16, 2024, 12:51 PM

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for spotting this!

@aloisklink aloisklink added this pull request to the merge queue Oct 18, 2024
Merged via the queue into mermaid-js:develop with commit df948bc Oct 18, 2024
23 checks passed
Copy link

mermaid-bot bot commented Oct 18, 2024

@eitsupi, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants