Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves E2E testing issues and issue #5343 #5344

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

rowanfr
Copy link
Contributor

@rowanfr rowanfr commented Feb 29, 2024

📑 Summary

This resolves E2E testing commit ID consistency issues with some git graph tests

Resolves #5343

📏 Design Decisions

This is an immensely basic PR that resolves commit ID consistency issues in E2E tests by giving them constant IDs for testing

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features. (Unnecessary to my knowledge)
  • 🔖 targeted develop branch

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 1b0b122
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e07d252bf5b6000898c757
😎 Deploy Preview https://deploy-preview-5344--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (1857eb1) to head (1b0b122).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5344       +/-   ##
============================================
- Coverage    76.47%   43.37%   -33.11%     
============================================
  Files          160       23      -137     
  Lines        14014     5130     -8884     
  Branches       820       23      -797     
============================================
- Hits         10717     2225     -8492     
+ Misses        3118     2904      -214     
+ Partials       179        1      -178     
Flag Coverage Δ
e2e ?
unit 43.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 156 files with indirect coverage changes

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome work in catching this, and thanks for the fix!

@aloisklink aloisklink added the Skip changelog Don't include in the changelog label Feb 29, 2024
@sidharthv96 sidharthv96 merged commit 2ac4e08 into mermaid-js:develop Feb 29, 2024
19 of 20 checks passed
Copy link

mermaid-bot bot commented Feb 29, 2024

@rowanfr, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip changelog Don't include in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E testing isn't working for PR #5152 failing due to randomized commit ID
3 participants