Link to webhelp #5316
Merged
Link to webhelp #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constributing page is not a plain markdown any more. It is part of the generated webhelp, so link to this. Some of the links were still to the symbolic link at the root of the repository.
The docs are availabe as webhelp, which is a nicer viewer than the plain markdown at GitHub. So a little search & replace: - "(./docs" --> "https://mermaid.js.org" vim command ":%s/(.\/docs/(https:\/\/mermaid.js.org/g" - ".md)" --> ".html)" vim command ":%s/.md)/.html)/g"
Replace each link to mermaid-js.github.io with corresponding link at the webhelp (/ website), using the redirects to get these links. (The redirects are to the http:// sites. I replace it with the https:// links of course.)
❌ Deploy Preview for mermaid-js failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5316 +/- ##
========================================
Coverage 79.15% 79.15%
========================================
Files 175 175
Lines 14514 14514
Branches 866 866
========================================
Hits 11488 11488
Misses 2823 2823
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@BaumiCoder, Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
There are still some old links to the markdown files or the mermaid-js.github.io site. I replaced them with the corresponding links to mermaid.js.org. (Similar changes like in PR mermaid-js/mermaid-live-editor#1405)
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch