-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Discord Invite to intro.md #5261
Conversation
1. Added a link to the Discord server
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5261 +/- ##
===========================================
+ Coverage 73.73% 79.51% +5.78%
===========================================
Files 164 175 +11
Lines 13864 14396 +532
Branches 741 855 +114
===========================================
+ Hits 10222 11447 +1225
+ Misses 3467 2755 -712
- Partials 175 194 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey, I had the same thought as you, but discovered that it is already done (and in more places than we had in mind): #5225 Seems like it is just not merged back to develop, and deployed to the live site. |
@thedustin Thank you for pointing this out. I see that it's been merged now, so I'll close my PR. |
I'm looking at the PR again @thedustin and it doesn't seem to have updated the page I was thinking of updating which was the website's contributing page. |
Hey FutzMonitor, as you can see the intro.md was adjusted too: |
📑 Summary
I added a Discord invite link to the
intro.html
file so that new contributors can quickly join the Mermaid DIscord server and chat with other members of the community.This doesn't resolve any issue in the issue tracker.
📏 Design Decisions
I simply created an invite link that didn't expire and added it to the page.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch