Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Discord Invite to intro.md #5261

Closed
wants to merge 1 commit into from

Conversation

FutzMonitor
Copy link
Contributor

@FutzMonitor FutzMonitor commented Feb 4, 2024

📑 Summary

I added a Discord invite link to the intro.html file so that new contributors can quickly join the Mermaid DIscord server and chat with other members of the community.

This doesn't resolve any issue in the issue tracker.

📏 Design Decisions

I simply created an invite link that didn't expire and added it to the page.

📋 Tasks

Make sure you

1. Added a link to the Discord server
Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit a9c08a8
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65bfbcea7e81f2000827075b
😎 Deploy Preview https://deploy-preview-5261--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b043d79) 73.73% compared to head (a9c08a8) 79.51%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5261      +/-   ##
===========================================
+ Coverage    73.73%   79.51%   +5.78%     
===========================================
  Files          164      175      +11     
  Lines        13864    14396     +532     
  Branches       741      855     +114     
===========================================
+ Hits         10222    11447    +1225     
+ Misses        3467     2755     -712     
- Partials       175      194      +19     
Flag Coverage Δ
e2e 85.09% <ø> (+6.93%) ⬆️
unit 43.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

@thedustin
Copy link
Contributor

Hey, I had the same thought as you, but discovered that it is already done (and in more places than we had in mind): #5225

Seems like it is just not merged back to develop, and deployed to the live site.

@FutzMonitor
Copy link
Contributor Author

@thedustin Thank you for pointing this out. I see that it's been merged now, so I'll close my PR.

@FutzMonitor FutzMonitor closed this Feb 5, 2024
@FutzMonitor FutzMonitor deleted the updateContribute branch February 5, 2024 00:11
@FutzMonitor FutzMonitor restored the updateContribute branch February 5, 2024 14:16
@FutzMonitor
Copy link
Contributor Author

I'm looking at the PR again @thedustin and it doesn't seem to have updated the page I was thinking of updating which was the website's contributing page.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants