Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Support async parsers [internal] #5233

Merged
merged 4 commits into from
Jan 27, 2024
Merged

refactor: Support async parsers [internal] #5233

merged 4 commits into from
Jan 27, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jan 24, 2024

📑 Summary

We're adding support for async parsers, to enable code splitting the langium parsers.

📏 Design Decisions

The new Diagram.fromText function replaces the getDiagramFromText function internally. (Doesn't affect mermaidAPI.getDiagramFromText)
As the mermaid.parse function was already async, there's no major external changes.

📋 Tasks

Make sure you

Add `Diagram.fromText`
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 442da6c
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65b0cb93f57f14000862f43e
😎 Deploy Preview https://deploy-preview-5233--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7c72cb) 44.38% compared to head (442da6c) 44.38%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5233   +/-   ##
=======================================
  Coverage   44.38%   44.38%           
=======================================
  Files          25       25           
  Lines        5227     5227           
  Branches       25       25           
=======================================
  Hits         2320     2320           
  Misses       2906     2906           
  Partials        1        1           
Flag Coverage Δ
unit 44.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96 sidharthv96 merged commit 969e2c1 into next Jan 27, 2024
23 of 24 checks passed
@sidharthv96 sidharthv96 deleted the AsyncParse branch January 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant