DOCS: update announcement bar #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mermaid-js failed.
|
huynhicode
requested review from
knsv,
ashishjain0512,
jgreywolf,
aloisklink and
pbrolin47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5193 +/- ##
==========================================
+ Coverage 76.57% 76.60% +0.03%
==========================================
Files 164 164
Lines 13820 13820
Branches 693 693
==========================================
+ Hits 10582 10587 +5
+ Misses 3080 3077 -3
+ Partials 158 156 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sidharthv96
reviewed
Jan 12, 2024
| class="unstyled text-white plausible-event-name=bannerClick" | ||
| class="unstyled flex-grow tracking-wide" |
There was a problem hiding this comment.
Why is plausible-event-name being removed?
There was a problem hiding this comment.
Inadvertent removal. Fixed, thanks.
aloisklink
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This PR contains updates to the Announcement bar.
Resolves # n/a
📏 Design Decisions
Design decisions made by the Mermaid Chart team.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch