Added support for millisecond and second to gantt tickInterval

[vertxxyz]

📑 Summary

I have added millisecond and second to tickInterval for gantt charts. Hopefully I haven't missed anything, it seems to work based on my testing :)

---
displayMode: compact
---
gantt
dateFormat SSS
tickInterval 6millisecond
axisFormat %Lms
section Frame
    1: 000, 18ms
    2: 5ms
    3: 13ms

Resolves #4771

📏 Design Decisions

Nothing worth considering.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines

• 💻 have added necessary unit/e2e tests.

• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.

• 🔖 targeted develop branch

• No tests were added (I don't see any previous tickInterval tests)

• I haven't used MERMAID_RELEASE_VERSION, if it's relevant please alter the PR.

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	e84ee32
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/64ee3bd53651180008d616cf
😎 Deploy Preview	https://deploy-preview-4778--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #4778 (e84ee32) into develop (6e51f8f) will increase coverage by 31.48%.
The diff coverage is 55.55%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #4778       +/-   ##
============================================
+ Coverage    45.55%   77.03%   +31.48%     
============================================
  Files           53      146       +93     
  Lines         6629    14581     +7952     
  Branches        32      592      +560     
============================================
+ Hits          3020    11233     +8213     
+ Misses        3608     3229      -379     
- Partials         1      119      +118     

Flag	Coverage Δ
e2e	83.90% <55.55%> (?)
unit	45.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js	86.37% <55.55%> (ø)

... and 140 files with indirect coverage changes

[sidharthv96]

Can you please add 2 integration tests like this?

mermaid/cypress/integration/rendering/gantt.spec.js

Lines 333 to 353 in 02517e8

	it('should render a gantt diagram with tick is 15 minutes', () => {
	imgSnapshotTest(
	`
	gantt
	title A Gantt Diagram
	dateFormat YYYY-MM-DD
	axisFormat %H:%M
	tickInterval 15minute
	excludes weekends
	section Section
	A task : a1, 2022-10-03, 6h
	Another task : after a1, 6h
	section Another
	Task in sec : 2022-10-03, 3h
	another task : 3h
	`,
	{}
	);
	});

[sidharthv96]

The provided example in PR is not rendering (link).

But the added tests are working. So is it an example with the code in the description?

[vertxxyz]

The provided example in PR is not rendering (link).

But the added tests are working. So is it an example with the code in the description?

It's working fine here. Perhaps it was just a caching issue. Thanks for helping me through this PR!

[sidharthv96]

[vertxxyz]

Does it work for you if you write 000 instead of 0?
0 works on my browser, but when I authored one with two "dates" 0 caused an infinite loop and I had to use 000 and 006 in my tests. Sorry, probably my fault for just running with what worked for me at the time instead of being specific with the format.

---
displayMode: compact
---
gantt
dateFormat SSS
tickInterval 6millisecond
axisFormat %Lms
section Frame
-     1: 0, 18ms
+     1: 000, 18ms
    2: 5ms
    3: 13ms

[sidharthv96]

@vertxxyz should that error be fixed?

[vertxxyz]

@sidharthv96 I have never seen the error you posted on my side, so I cannot say.
I imagine it's to do with the incorrect date format that worked fine for me. Can you test it with the change I mentioned?
If it works, then it's not a real issue, just one with the example diagram markup I first posted.

[sidharthv96]

The issues is present in firefox, and using 000 does fix it.

[mermaid-bot]

@vertxxyz, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.