Add initThrowsErrors()

[MindaugasLaganeckas]

📑 Summary

looking into several issues related to propagating the syntax errors from mermaid to other clients, e.g. mermaid-cli. By inspecting the code of mermaid.js (

mermaid/src/mermaid.js

Line 122 in d040883

} catch (e) {

), I can see that all errors are caught on the mermaid level and never propagated to the clients. That is a problem described in several issues. One is here (mermaid-js/mermaid-cli#138)

Resolves #2378

📏 Design Decisions

Make another function called init(), rename existing one to initThrowsErrors(). The new init() calls initThrowsErrors() and try-catch lives in init(). Then clients can choose either to call init() or initThrowsErrors()

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 🔖 targeted develop branch

[ashishjain0512]

Hey

Is this PR still a draft?

Regards,
Ashish

[MindaugasLaganeckas]

@ashishjain0512 : yes, I want to add few tests. Thanks for asking! Would you be willing to have a look at the idea and provide early feedback?

[MindaugasLaganeckas]

I have received a confirmation of the validity of the idea from @knsv in slack thread https://mermaid-talk.slack.com/archives/CL256P19N/p1633101057039000 Now if someone can review the implementation of the idea? 😉

[johanneswuerbach]

Looks like this was approved, any further changes required here? :-)

[MindaugasLaganeckas]

Please, let me know if the PR can be somehow improved, so that it can be merged.
I think the motivation I have provided is enough to see the PR's value.
😄

[MindaugasLaganeckas]

The newest issue related to my PR in mermaid-cli project: mermaid-js/mermaid-cli#276