Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode chars in labels #13

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Allow unicode chars in labels #13

merged 1 commit into from
Dec 1, 2014

Conversation

codebeige
Copy link
Contributor

In order to support any unicode word chars in labels, I have added a bunch of unicode ranges to 'ALPHA'. It might look a little bit hacky, but there is no better or more beautiful solution that I am currently aware of.

Also added a unit test from the example in issue #9.

knsv added a commit that referenced this pull request Dec 1, 2014
@knsv knsv merged commit 3a65cd1 into mermaid-js:master Dec 1, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 1, 2014

Thanks! Glad to get help with the unicode ranges. Also good with the additional test.

@codebeige
Copy link
Contributor Author

Happy to contribute. I really like your idea. You can probably also close #9 now.

knsv pushed a commit that referenced this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants