Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify font-settings #989

Closed
knsv opened this issue Oct 12, 2019 · 2 comments
Closed

Simplify font-settings #989

knsv opened this issue Oct 12, 2019 · 2 comments

Comments

@knsv
Copy link
Collaborator

knsv commented Oct 12, 2019

One of the most persistant problems users have when integrating mermaid into their sites is setting the font properly, specifically so that bound are set correctly.

The root cause for this is related to font-settings. If the hidden rendering of the diagram has different font-settings then the final font settings the sizing of the boxes etc will differ.

It would be great if it was possieble to set the font in the configuration. Then the integrator only would need to provide a font-family to the page and set the option font-family in the mermaid options for the rendering to be correct.

This could potentially be set using css variables. So that the variables are being set from configuration at initialize.

@nothingismagick
Copy link
Contributor

nothingismagick commented Oct 12, 2019 via email

@knsv knsv self-assigned this Oct 12, 2019
@knsv
Copy link
Collaborator Author

knsv commented Oct 12, 2019

thanks for the heads up. Will set a default value then for IE to be overridden by a css variable so IE11 will get the default.

knsv added a commit that referenced this issue Oct 12, 2019
@knsv knsv closed this as completed Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants