-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid v10 #4103
Comments
Do we know when v10 is expected?
We may also want to remove mermaid/packages/mermaid/src/config.type.ts Lines 6 to 9 in 0c18c03
Awesome, that makes life a bit easier for Mermaid experts! |
Can you make a PR with your changes?, I'll publish the #3397 is a major one to configs that might need some discussions on. |
My PR is at #4112. However, I made that PR without any breaking changes, so it can wait until a It should be pretty easy to add a config validator too using ajv too if #4112 gets merged (I believe this is the package that ESLint plugins use), in order to implement #3397. We can even add it to a |
As mermaid v10 provide a async render function, can we expect a recent v11 that split mermaid to I can see that mindmap was splited to a sperated package, but somehow moved back, and this is not what I am expected. We can still have a |
Please open a new issue/discussion. I was pondering an idea to split all the new diagrams like mindmap and flowchart-elk into a separate single package (having individual packages for each diagram will affect adoption significantly). The size difference is significant, but as all diagrams are lazy loaded now, it won't impact most users as only diagrams they use are downloaded. Only the people who bundle without splitting will be affected. But let's discuss this in a new thread. Thanks! |
Why are you saying this, as long as the input is made by user (not me), it means I have to pack all mermaid code for them. But with sperate packages, I can pack them each much more easily and do a pre-check about users input and register new diagram for them by downloading new chunks containing the diagram, also it gives me a opportunity to drop some diagram which I "do not want to have support", they will be just gone. But with a whole package, it will probably pack into a single chunk by webpack and vite without advanced code splitting configuration and users do need to download them all before using anyone. It's pretty hacky for developers to "remove" some codes which is actually imported and used by the module entry, also not easy for noob developers to add those code spliting configuration. |
- https://mermaid.js.org/syntax/xyChart.html - https://mermaid.js.org/syntax/quadrantChart.html - mermaid-js/mermaid#4383 Updated from Mermaid v9 to v10 (breaking changes): - mermaid-js/mermaid#4103 - https://mermaid.js.org/config/usage.html#using-mermaid-run
Breaking changes planned in v10
mermaid.init
is not using theconfig
that's passed. #3406PS @aloisklink, we have blank issues now.
The text was updated successfully, but these errors were encountered: