Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined sequenceConfig fails #109

Closed
timelyportfolio opened this issue Jan 20, 2015 · 2 comments
Closed

undefined sequenceConfig fails #109

timelyportfolio opened this issue Jan 20, 2015 · 2 comments

Comments

@timelyportfolio
Copy link

It appears there is a bug in this line. I believe it should be

    if (typeof sequenceConfig !== 'undefined') {
      seq.setConf(JSON.parse(sequenceConfig));
    }

rather than the existing

    if (sequenceConfig !== 'undefined') {
      seq.setConf(JSON.parse(sequenceConfig));
    }
knsv added a commit that referenced this issue Jan 20, 2015
@knsv
Copy link
Collaborator

knsv commented Jan 20, 2015

Thanks! Must have come along with the sequence config feature. Should be fixed with the lastest commit. (Not released yet though).

@knsv
Copy link
Collaborator

knsv commented Jan 25, 2015

A fix has been included in release 0.3.3

@knsv knsv closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants