-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs links in the Editor's Docs button #1335
Conversation
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Whoops!
There is no unit tests for routes themselves, so I didn't add any. |
@sidharthv96 can you review this PR when you are free? |
@sidharthv96 @aloisklink sorry to bump this again but it's annoying to not have this fix merged yet. Is there anything I forgot to do that prevents the review/merge? |
@Abrifq The root cause of the issue was mermaid-js/mermaid#4989, not the wrong URLs here. I've fixed that with mermaid-js/mermaid#5250. Also, your PR was a duplicate of an existing one #1329 which added to some confusions. |
Can you add one more change? Currently we're using |
I assume you meant |
Yes, my bad. 😅 |
📑 Summary
Brief description about the content of your PR:
Updates the links to redirect correctly on the new documentation site.
Resolves: none. I figured out it would be better to contribute instead of explaining the issue with my broken English.
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable:
📋 Tasks
Make sure you
develop
branch