Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeToast #44

Merged
merged 8 commits into from
Jul 21, 2020
Merged

Add removeToast #44

merged 8 commits into from
Jul 21, 2020

Conversation

phoward38
Copy link
Collaborator

  • Added removeToast function
    • animate argument for removing immediately vs. removing w/ animation
  • Added keepVisible argument to showToast

@phoward38 phoward38 requested a review from merlinoa July 21, 2020 20:02
@phoward38 phoward38 mentioned this pull request Jul 21, 2020
Closed
@phoward38 phoward38 changed the title Add/clear toast remove toast Add removeToast Jul 21, 2020
merlinoa
merlinoa reviewed Jul 21, 2020
View reviewed changes
merlinoa
merlinoa reviewed Jul 21, 2020
View reviewed changes
merlinoa
merlinoa reviewed Jul 21, 2020
View reviewed changes
merlinoa
merlinoa requested changes Jul 21, 2020
View reviewed changes
Copy link
Owner

@merlinoa merlinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please make those minor changes from my comments and you can go ahead and merge this.

@phoward38
Copy link
Collaborator Author

@merlinoa Resolved remaining issues

@merlinoa merlinoa merged commit 528b4d6 into master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlinoa merlinoa merlinoa requested changes

Assignees

@merlinoa merlinoa

@phoward38 phoward38

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phoward38 @merlinoa