feat: vendor libgit2 (via git2go)
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 71.04% 71.04%
=======================================
Files 55 55
Lines 3119 3119
=======================================
Hits 2216 2216
Misses 574 574
Partials 329 329 Continue to review full report at Codecov.
|
patrickdevivo
force-pushed
the
vendor-libgit2
branch
from
1f3ed71 to
4395283
Compare
|
Isn't possible to let the use choose if use the vendored or the system libgit2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the instructions here (
mainbranch, or vendored static linking) to vendorlibgit2andgit2gointo this repo.We're encountering an issue with homebrew installations when the upstream
libgit2gets an update and we haven't upgradedmergestatto support the newlibgit2version. Homebrew doesn't seem to allow us to pin to a particular version, so installations begin breaking.I see two possible solutions:
libgit2(andgit2go) into this repo so that builds will statically link it, no need to depend on a systemlibgit2(what this PR does)homebrewinstallation to just copy a pre-built binaryOr maybe both...