Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace uses of variadic .listen function #865

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Sep 15, 2022

The documentation references .listen(<port>) in several places, but this variadic function is deprecated in Fastify v4 and throws this warning:

(node:254) [FSTDEP011] FastifyDeprecation: Variadic listen method is deprecated. Please use ".listen(optionsObject)" instead. The variadic signature will be removed in fastify@5.

Since the current package.json requires Fastify v4+, this should be safe to do:

"fastify": "^4.0.0",

Deprecation guide: https://github.com/fastify/fastify/blob/2fd918298d55aaab74585c0b71081ad40988b280/docs/Guides/Migration-Guide-V4.md#deprecation-of-variadic-listen-signature

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5dc2ab4 into mercurius-js:master Sep 15, 2022
@blimmer blimmer deleted the remove-use-of-variadic-listen branch September 15, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants