implement support for condensed bit masks #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO this is a somewhat exotic feature... Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com> Signed-off-by: Michael Hahn <michael.hahn@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
kayoub5
reviewed
Jan 21, 2025
|
|
||
| # TODO: this is pretty slow. replace it by | ||
| # `self.bit_mask.bit_count()` once we require python >= | ||
| # 3.10. |
There was a problem hiding this comment.
we are not that far away from 3.9 end of life, you may drop it now
There was a problem hiding this comment.
I promised myself to support python 3.8 until ubuntu 20.04 is EOL. Fortunately, this is not too far off anymore (April), then we can do the same for Ubuntu 22.04 / python 3.10. I've added an item to the TODO list, though: #286 . (That said, I suspect that the performance impact of converting the integer to a string and counting the one characters is lower than the interpreter overhead of doing two instead of one function calls. For compiled languages this is a completely different story...)
kayoub5
reviewed
Jan 21, 2025
kayoub5
reviewed
Jan 21, 2025
this basically means using `isinstance(*, SupportsBytes)` instead of `isinstance(*, bytes)`. Interestingly enough, `isinstance(bytearray(), SupportsBytes)` is `False`, so we have to explicitly check for `bytearray` as well. thanks to [at]kayoub5 for the catch! Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
andlaus
force-pushed
the
condensed_bitmasks
branch
from
e4d7724 to
5b2b0d9
Compare
kayoub5
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this is a somewhat exotic feature, but since it is in the spec there probably is somebody out there who uses it...
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information