feat: garm runners will be reflected into kubernetes as runner resource #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalgalaw
requested review from
bavarianbidi,
maigl and
H777K
as code owners
rafalgalaw
force-pushed
the
feat/show-runners
branch
6 times, most recently
from
986d63d
to
7c92935
Compare
bavarianbidi
requested changes
Nov 2, 2023
rafalgalaw
force-pushed
the
feat/show-runners
branch
2 times, most recently
from
2b4e97e
to
6a30799
Compare
rafalgalaw
force-pushed
the
feat/show-runners
branch
2 times, most recently
from
4b66b5b
to
844bec6
Compare
bavarianbidi
requested changes
Dec 4, 2023
bavarianbidi
reviewed
Dec 4, 2023
Closed
Closed
|
After communication with @bavarianbidi, I will move the auth refactoring to a separate PR |
rafalgalaw
force-pushed
the
feat/show-runners
branch
2 times, most recently
from
f2df4ef
to
013d6e3
Compare
rafalgalaw
force-pushed
the
feat/show-runners
branch
from
557993c
to
be1e759
Compare
|
rafalgalaw
force-pushed
the
feat/show-runners
branch
from
b42cf38
to
310ec43
Compare
rafalgalaw
force-pushed
the
feat/show-runners
branch
from
310ec43
to
b601b8d
Compare
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
bavarianbidi
reviewed
Dec 8, 2023
|
|
||
| func (r *RunnerReconciler) PollRunnerInstances(ctx context.Context, eventChan chan event.GenericEvent) { | ||
| log := log.FromContext(ctx) | ||
| ticker := time.NewTicker(5 * time.Second) |
There was a problem hiding this comment.
should we have this configurable? maybe it's a nice feature - wdyt?
There was a problem hiding this comment.
so one could supply a flag in which interval runners are getting polled?
There was a problem hiding this comment.
Maybe I do this in a separate PR, I want to get this feature finally shipped 😅
There was a problem hiding this comment.
as discussed, i'm fine with adding an additional flag in a separate PR
bavarianbidi
reviewed
Dec 8, 2023
Co-authored-by: Mario Constanti <github@constanti.de>
Co-authored-by: Mario Constanti <github@constanti.de>
Co-authored-by: Mario Constanti <github@constanti.de>
Co-authored-by: Mario Constanti <github@constanti.de>
bavarianbidi
reviewed
Dec 8, 2023
rafalgalaw
force-pushed
the
feat/show-runners
branch
from
c4fcbbc
to
3659c47
Compare
rafalgalaw
commented
Dec 8, 2023
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
changed the title
bavarianbidi
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
one can now list and with
one can delete a runner from within a cluster.
Also, if accidently a runner get deleted via cli from within the garm-server itself, der controller cleans up not matching runner CRs in k8s
Todo: