Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print-columns and ready condition aggregate #104

Merged
merged 6 commits into from
May 13, 2024
Merged

fix: print-columns and ready condition aggregate #104

merged 6 commits into from
May 13, 2024

Conversation

rafalgalaw
Copy link
Collaborator

Added some better reasons to conditions and use Ready condition as aggregate for all other conditions present. For example if the poolManager is not ready Ready=False with a Reason=ComponentNotReady and more details provided in the separate PoolManager condition:

  status:
    conditions:
    - lastTransitionTime: "2024-03-11T13:34:50Z"
      message: Pool Manager is not running
      reason: ComponentNotReady
      status: "False"
      type: Ready
    - lastTransitionTime: "2024-03-11T13:34:50Z"
      message: 'failed to update tools for repo cnt-dev/rthalho-test: fetching tools:
        Unauthorized'
      reason: PoolManagerFailure
      status: "False"
      type: PoolManager
    - lastTransitionTime: "2024-03-05T09:27:24Z"
      message: ""
      reason: FetchingSecretRefSuccess
      status: "True"
      type: SecretReference
    id: 70056770-a244-4fa4-b347-3b5d03cda874

and fixed print columns, so with the -owide flag one gets more details about the current state
image

@CLA-Mercedes-Benz
Copy link

CLA-Mercedes-Benz commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rafalgalaw rafalgalaw changed the title Fix/kubectl printcolumn Fix: print-columns and ready condition aggregate Mar 11, 2024
@rafalgalaw rafalgalaw changed the title Fix: print-columns and ready condition aggregate fix: print-columns and ready condition aggregate Mar 11, 2024
bavarianbidi
bavarianbidi requested changes May 6, 2024
View reviewed changes
Copy link
Member

@bavarianbidi bavarianbidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few smaller nits - but all in all 👍

pkg/util/conditions/condition_types.go Outdated Show resolved Hide resolved
pkg/util/conditions/condition_types.go Outdated Show resolved Hide resolved
internal/controller/repository_controller.go Outdated Show resolved Hide resolved
internal/controller/organization_controller.go Outdated Show resolved Hide resolved
internal/controller/enterprise_controller.go Outdated Show resolved Hide resolved
pkg/util/conditions/condition_types.go Outdated Show resolved Hide resolved
@rafalgalaw rafalgalaw merged commit 700efd7 into main May 13, 2024
3 checks passed
@rafalgalaw rafalgalaw deleted the fix/kubectl-printcolumn branch May 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bavarianbidi bavarianbidi bavarianbidi approved these changes

@maigl maigl Awaiting requested review from maigl maigl is a code owner

@H777K H777K Awaiting requested review from H777K H777K is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafalgalaw @CLA-Mercedes-Benz @bavarianbidi