Add wasm plugin benchmark #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors `_examples/15_cel_plugin` so that it can be run both as a test and as a benchmark and adds a flag to `WasmConfig` to disable/enable debug logging. The benchmark disables all logging to avoid interfering with the benchmark results. I have also updated the Makefiles to run this benchmark with `make bench`. I have also added a new test case (`testRegexComplexSuccess`) to evaluate a slightly more involved regex. The results are encouraging, even if this test is probably dominated by I/O. The following are the results of the baseline compared to the latest pre-release (mercari#124). ``` │ before.txt │ after.txt │ │ sec/op │ sec/op vs base │ Federation/success-10 0.0005831n ± 6% 0.0005571n ± 7% -4.48% (p=0.032 n=20) Federation/success_complex-10 0.0005713n ± 5% 0.0005227n ± 8% -8.51% (p=0.000 n=20) Federation/failure-10 0.0003323n ± 5% 0.0002961n ± 8% -10.90% (p=0.000 n=20) geomean 0.0004802n 0.0004417n -8.00% ``` Showing an improvement between 4 and 10% at run-time. Let me know if the approach to configuration works for you, and if the refactoring of the test is fine. I mostly just cobbled this together to make get the results quickly! Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
|
Thank you for your contribution ! We added an example for profiling of the wasm plugin ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
_examples/15_cel_pluginso that it can be run both as a test and as a benchmark and adds a flag toWasmConfigto disable/enable debug logging. The benchmark disables all logging to avoid interfering with the benchmark results. I have also updated the Makefiles to run this benchmark withmake bench.I have also added a new test case (
testRegexComplexSuccess) to evaluate a slightly more involved regex.The results are encouraging, even if this test is probably dominated by I/O. The following are the results of the baseline compared to the latest pre-release (#124).
Showing an improvement between 4 and 10% at run-time. Let me know if the approach to configuration works for you, and if the refactoring of the test is fine. I mostly just cobbled this together to make get the results quickly!
Please notice that this PR does not concern
_examples/16_code_gen_plugin.