changed data grid sort page query logic, added sidebar drag drop, added viz config panel changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her components Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
paulstn
force-pushed
the
erics-look-and-feel
branch
from
affb192
to
7f24bf5
Compare
paulstn
changed the title
mengweieric
reviewed
Oct 20, 2023
| @@ -29,7 +29,7 @@ export const Visualization = ({ | |||
| // Markdown, it does not depend on if there is data | |||
| if (vis.id === VIS_CHART_TYPES.Text) return [true, '']; | |||
|
|
|||
| if (isEmpty(series)) return [false, VISUALIZATION_ERROR.INVALID_DATA]; // series is required to any visualization type | |||
There was a problem hiding this comment.
If the query is not valid and returns no data, what would it show?
There was a problem hiding this comment.
I assumed that an empty series would mean that data hasn't been put in yet. Shouldn't this be the case? For invalid queries there are other checks in this file that will display invalid data if invalid.
There was a problem hiding this comment.
we can check with UX team on this
...lorer/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
Outdated
Show resolved
Hide resolved
...orer/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.scss
Show resolved
Hide resolved
ps48
reviewed
Oct 20, 2023
ps48
reviewed
Oct 20, 2023
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
mengweieric
merged commit 0be66e9
into
mengweieric:feature/match-look-and-feel
1 of 4 checks passed
mengweieric
pushed a commit
that referenced
this pull request
Oct 30, 2023
change github actions file and add necessary files
mengweieric
pushed a commit
that referenced
this pull request
Feb 19, 2024
change github actions file and add necessary files (cherry picked from commit 1b5f971) Signed-off-by: Derek Ho <dxho@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changed data grid sort page logic, added sidebar drag drop, added viz config panel changes
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.