Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullcalendar scheduler #38

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Conversation

kimpellikaan
Copy link
Contributor

@JelteMX I have implemented the scheduler with license key support. I have not been able to load the scheduler conditionally though. The problem is that I can't add the scheduler (scheduler.js) to the current scope from inside the widget. This is needed for the full calendar to work with the scheduler though.

The only way I can think of to pull this off is to call a new widget (e.g. CalenderWithScheduler later to be call the child) from the current Calendar widget (later to be called parent). The issue I was facing while trying that was, once the "parent" is called that widget occupies the widget location and cant be overwritten by a child. If you know a way to pass the parent state to the child is such a way that the child can manipulate the location then the scheduler could be loaded conditionally.

Let me know.

@JelteMX JelteMX self-assigned this Jul 8, 2016
@JelteMX JelteMX merged commit 4097f1d into mendixlabs:master Dec 13, 2016
@JelteMX
Copy link
Contributor

JelteMX commented Dec 13, 2016

The Scheduler addon was accepted. I did change this somewhat. Because most users won't be using the scheduler, it's best to create a separate widget for this. So I included this as a separate widget, where you will have to set the resources, license key etcetera.

@kimpellikaan
Copy link
Contributor Author

@JelteMX If you want to create a separate widget for this can we brand it under our company? Say WebFlight?

@JelteMX
Copy link
Contributor

JelteMX commented Dec 15, 2016

No it's not necessary. In the latest release I created a separate widget under the same package. So in the Modeler you will see "Calendar" and "Calender (with Scheduler)". If you use that one, the License key for example, is required. So in that sense, it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants