Skip to content

Commit

Permalink
Fix circle reference log (#71)
Browse files Browse the repository at this point in the history
The logger.debug cause circle reference issue when using microflow as a data source in Mendix 7.13.1
  • Loading branch information
Andries-Smit authored and JelteMX committed Jun 12, 2018
1 parent 8e6e851 commit 20bbd60
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var pkg = require("./package.json"),
paths = widgetBuilderHelper.generatePaths(pkg),
xmlversion = widgetBuilderHelper.xmlversion;

gulp.task("default", function() {
gulp.task("default", ["compress"], function() {
gulp.watch("./src/**/*", ["compress"]);
gulp.watch("./src/**/*.js", ["copy:js"]);
});
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "calendar",
"version": "5.4.1",
"version": "5.4.2",
"description": "This is a calendar widget for Mendix. It shows a Calendar and can render objects as events in it.",
"license": "Apache License, Version 2.0, January 2004",
"author": "Mendix 2016",
Expand Down Expand Up @@ -33,4 +33,4 @@
"folders": "node ./node_modules/gulp/bin/gulp folders",
"modeler": "node ./node_modules/gulp/bin/gulp modeler"
}
}
}
4 changes: 2 additions & 2 deletions src/calendar/widget/calendar.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ define([
this._fetchPaginatedEvents(view.start, view.end);
}
} else if (this.dataSourceType === "contextmf" && this.contextDatasourceMf) {
logger.debug(this.id + "._fetchObjects contextmf", this._mxObj);
logger.debug(this.id + "._fetchObjects contextmf");
if (this._mxObj) {
this._execMF(this._mxObj, this.contextDatasourceMf, lang.hitch(this, this._prepareEvents));
}
Expand Down Expand Up @@ -734,7 +734,7 @@ define([
action.origin = this.mxform;
}

logger.debug(this.id + "._execMF", mf, action);
logger.debug(this.id + "._execMF", mf);
mx.data.action(action, this);
} else if (cb) {
logger.debug(this.id + "._execMF: no microflow defined");
Expand Down
4 changes: 2 additions & 2 deletions src/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Calendar" version="5.4.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Calendar" version="5.4.2" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="calendar/calendar.xml"/>
<widgetFile path="calendar/calendar-scheduler.xml"/>
Expand All @@ -10,4 +10,4 @@
<file path="calendar/widget/"/>
</files>
</clientModule>
</package>
</package>
Binary file modified test/widgets/calendar.mpk
Binary file not shown.

0 comments on commit 20bbd60

Please sign in to comment.