Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIR-796] feat(api/types): Add action and wait time validation for scrape requests #1146

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

ftonato
Copy link
Collaborator

@ftonato ftonato commented Feb 7, 2025

  • Implement max actions limit (15 actions)
  • Add total wait time calculation for actions
  • Increase max waitFor time to 60 seconds
  • Refactor scrape options schema to include validation

…rape requests

- Implement max actions limit (15 actions)
- Add total wait time calculation for actions
- Increase max waitFor time to 60 seconds
- Refactor scrape options schema to include validation
@ftonato ftonato requested review from mogery and nickscamara February 7, 2025 21:21
Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

apps/api/src/controllers/v1/types.ts Outdated Show resolved Hide resolved
@ftonato ftonato merged commit 3608256 into main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants