struct {D,R}av1d{Sequence,Frame}Header: Replace Rav1dRefs with Option<Arc<DRav1d<_, _>>>s
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/struct-Rav1dWarpedMotionParams-mutate-through-atomics
branch
from
4c5076a to
cd8f316
Compare
kkysen
force-pushed
the
kkysen/struct-Rav1dSequence-FrameHeader-Arcify
branch
3 times, most recently
from
46db563 to
37c1fc8
Compare
kkysen
force-pushed
the
kkysen/struct-Rav1dWarpedMotionParams-mutate-through-atomics
branch
from
cd8f316 to
88d9187
Compare
kkysen
force-pushed
the
kkysen/struct-Rav1dSequence-FrameHeader-Arcify
branch
from
5ed3edb to
da55b98
Compare
randomPoison
approved these changes
Jan 9, 2024
kkysen
force-pushed
the
kkysen/struct-Rav1dSequence-FrameHeader-Arcify
branch
from
da55b98 to
27defb4
Compare
Base automatically changed from
kkysen/struct-Rav1dWarpedMotionParams-mutate-through-atomics
to
main
January 11, 2024 00:15
…ption<Arc<DRav1d<_, _>>>`s.
As these types are heavily used unlike the other `Rav1dRef`ed types,
`impl Deref for DRav1d` is added, `deref`ing to `R` as that's the type used primarily in Rust.
And to simplify uses and avoid triple derefs (including an `Arc` deref and `Option::unwrap`) at use sites,
a `let {frame,seq}_hdr = &***{f,c}.{frame,seq}_hdr.as_ref().unwrap();` is refactored out in each `fn` where it's used.
…` conversion by returning the full `DRav1d` instead of dropping the `D`.
kkysen
force-pushed
the
kkysen/struct-Rav1dSequence-FrameHeader-Arcify
branch
from
27defb4 to
ca294df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these types are heavily used unlike the other
Rav1dRefed types,impl Deref for DRav1dis added,derefing toRas that's the type used primarily in Rust.And to simplify uses and avoid triple derefs (including an
Arcderef andOption::unwrap) at use sites, alet {frame,seq}_hdr = &***{f,c}.{frame,seq}_hdr.as_ref().unwrap();is refactored out in eachfnwhere it's used.Furthermore, similarly to #661,
.update_rav1d()s are skipped. Although these types are indeed read, they are meant to be read-only, so this should be okay to do.Unlike the previous
Arcified types in #659 and #661, theseRav1dRefs were pooled, which theArcreplacement is not. However, those pools were not thread-local, so it's not clear if it is a perf regression to remove them (we'll check). Either way, the API ofArcshould be similar enough to a pooledArc(e.x.refpool) that we can switch to it later if perf demands it.