Backport type changes for time_scale, num_units_in_tick, and num_units_in_decoding_tick from dav1d 1.3.0
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_tick unsigned All of them are 32 bits values that shall be > 0 Signed-off-by: James Almer <jamrial@gmail.com>
kkysen
approved these changes
Apr 24, 2024
| @@ -82,7 +82,7 @@ pub struct Dav1dPicture { | |||
| pub mastering_display: Option<NonNull<Rav1dMasteringDisplay>>, | |||
| pub itut_t35: Option<NonNull<Dav1dITUTT35>>, | |||
| pub n_itut_t35: usize, | |||
| pub reserved: [uintptr_t; 3], | |||
| pub reserved: [uintptr_t; 4], | |||
There was a problem hiding this comment.
I'm curious where this extra room came from.
There was a problem hiding this comment.
Don't know. This was reduced to 3 when n_itut_t35 was added and now it's changed back to 4.
There was a problem hiding this comment.
Yeah I saw it was reduced then which made sense because the new field used up one of them, but the change here doesn't change the size.
kkysen
reviewed
Apr 24, 2024
kkysen
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time_scale,num_units_in_tick, andnum_units_in_decoding_tickof Backport: Reduce the size of some public structs #505.