Skip to content

fix(ble): fix race condition for MAC addr device ID in sample #14

fix(ble): fix race condition for MAC addr device ID in sample

fix(ble): fix race condition for MAC addr device ID in sample #14

Triggered via pull request June 13, 2024 21:11
Status Failure
Total duration 1m 38s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
1m 28s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
Run compliance checks on patch series (PR): Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 1effbd21b5e85f54d7d7371f6b4d440e8f17df20: author email (Gillian Minnehan <gillian@memfault.com>) needs to match one of the signed-off-by entries.
Run compliance checks on patch series (PR): Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 1: T5 Title contains the word 'wip' (case-insensitive): "wip" 1: T8 Title is too short (3<5): "wip" 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "wip" 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing
Run compliance checks on patch series (PR): GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes 1effbd21b5e85f54d7d7371f6b4d440e8f17df20: include/memfault_ncs.h:29: trailing whitespace. 1effbd21b5e85f54d7d7371f6b4d440e8f17df20: include/memfault_ncs.h:30: trailing whitespace.
Run compliance checks on patch series (PR): Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. TRAILING_WHITESPACE: trailing whitespace File:include/memfault_ncs.h Line:29 TRAILING_WHITESPACE: trailing whitespace File:include/memfault_ncs.h Line:30 LEADING_SPACE: please, no spaces at the start of a line File:samples/bluetooth/peripheral_mds/src/main.c Line:333 C99_COMMENTS: do not use C99 // comments File:samples/bluetooth/peripheral_mds/src/main.c Line:333 LEADING_SPACE: please, no spaces at the start of a line File:samples/bluetooth/peripheral_mds/src/main.c Line:334 LEADING_SPACE: please, no spaces at the start of a line File:samples/bluetooth/peripheral_mds/src/main.c Line:335
Run compliance checks on patch series (PR): KconfigBasic.txt#L1
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details. Undefined Kconfig symbols: warning: undefined symbol BOARD_NRF52820DONGLE_NRF52820: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf52820dongle/Kconfig:9: config BOARD_ENABLE_DCDC bool "Enable DCDC mode" default y select SOC_DCDC_NRF52X depends on BOARD_NRF52820DONGLE_NRF52820 warning: undefined symbol BOARD_NRF52833DONGLE_NRF52833: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf52833dongle/Kconfig:9: config BOARD_ENABLE_DCDC bool "Enable DCDC mode" default y select SOC_DCDC_NRF52X depends on BOARD_NRF52833DONGLE_NRF52833 warning: undefined symbol BOARD_NRF52840GMOUSE_NRF52840: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf52840gmouse/Kconfig:9: config BOARD_ENABLE_DCDC bool "Enable DCDC mode" default y select SOC_DCDC_NRF52X depends on BOARD_NRF52840GMOUSE_NRF52840 warning: undefined symbol BOARD_NRF52DMOUSE_NRF52832: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf52dmouse/Kconfig:9: config BOARD_ENABLE_DCDC bool "Enable DCDC mode" default y select SOC_DCDC_NRF52X depends on BOARD_NRF52DMOUSE_NRF52832 warning: undefined symbol BOARD_NRF52KBD_NRF52832: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf52kbd/Kconfig:9: config BOARD_ENABLE_DCDC bool "Enable DCDC mode" default y select SOC_DCDC_NRF52X depends on BOARD_NRF52KBD_NRF52832 warning: undefined symbol BOARD_NRF7002DK_NRF5340_CPUAPP: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:15: config BOARD_ENABLE_DCDC_APP bool "Enable Application MCU DCDC converter" default y select SOC_DCDC_NRF53X_APP depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:20: config BOARD_ENABLE_DCDC_NET bool "Enable Network MCU DCDC converter" default y select SOC_DCDC_NRF53X_NET depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:25: config BOARD_ENABLE_DCDC_HV bool "Enable High Voltage DCDC converter" default y select SOC_DCDC_NRF53X_HV depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:30: choice BT_HCI_BUS_TYPE bool default BT_HCI_IPC if BT depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:34: config HEAP_MEM_POOL_SIZE int default 4096 if BT_HCI_IPC depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:37: config BT_HCI_VS bool default y if BT depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/./boards/nordic/nrf7002dk/Kconfig:40: config BOARD_ENABLE_CPUNET bool "Enable nRF53 Network MCU" default y if BT || NRF_802154_SER_HOST select SOC_NRF_GPIO_FORWARDER_FOR_NRF5340 if n depends on BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF5340_CPUAPP_NS || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001_NS help This option
Run compliance checks on patch series (PR)
Process completed with exit code 1.
TRAILING_WHITESPACE: include/memfault_ncs.h#L29
include/memfault_ncs.h:29 trailing whitespace
TRAILING_WHITESPACE: include/memfault_ncs.h#L30
include/memfault_ncs.h:30 trailing whitespace
C99_COMMENTS: samples/bluetooth/peripheral_mds/src/main.c#L333
samples/bluetooth/peripheral_mds/src/main.c:333 do not use C99 // comments
Run compliance checks on patch series (PR)
Process completed with exit code 5.
Run compliance checks on patch series (PR)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
LEADING_SPACE: samples/bluetooth/peripheral_mds/src/main.c#L333
samples/bluetooth/peripheral_mds/src/main.c:333 please, no spaces at the start of a line
LEADING_SPACE: samples/bluetooth/peripheral_mds/src/main.c#L334
samples/bluetooth/peripheral_mds/src/main.c:334 please, no spaces at the start of a line
LEADING_SPACE: samples/bluetooth/peripheral_mds/src/main.c#L335
samples/bluetooth/peripheral_mds/src/main.c:335 please, no spaces at the start of a line
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "compliance.xml". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
compliance.xml Expired
38.6 KB