[REVIEW] 249 Simplify Marker Upload #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matheus Blanco <msallesblanco@gmail.com>
Co-authored-by: Matheus Blaco <msallesblanco@gmail.com>
pablodiegoss
force-pushed
the
develop
branch
10 times, most recently
from
50d4c28 to
fd01e19
Compare
2 tasks
|
This branch is too old and conflicting with newer commits on develop, I've merged these commits into a new branch here since I don't have access to the original repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue includes bring the part of generating a marker, already to the form of sending a marker.
Resolves (Issues)
#249
General tasks performed
@MatheusBlanco helped me with this issue.
Have you confirmed the application builds locally without error? See here.
☠️ ☠️ Reason: This issues uses a pymarker lib, which contains a bug when trying to submit a transparent marker.
For transparent images instead of the generated marker having a white background, it ends up turning all black.
Example:
Image
Generated Marker:
😃 😃 Me, @manueng and @darmsDD have already solved this problem in the pymarker and as soon as the PR is accepted, this bug will be fixed here.