Fix last temp file merge, bump core and package version #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested changes
Dec 12, 2022
| @@ -25,8 +21,6 @@ defmodule Membrane.File.Sink.MultiTest do | |||
|
|
|||
| setup :state_and_ctx | |||
|
|
|||
| setup :verify_on_exit! | |||
There was a problem hiding this comment.
use Membrane.File.TestCaseTemplate already sets this up
FelonEkonom
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a bug when using
File.SinkandFile.SeekEvent- on termination, the descriptors of opened files are closed before cleanup function fromResourceGuardare ran, what results in error when trying to copy the contents of the temporary file over to the main file. This error hasn't been noticed in other cases, sinceCommonFile.close!on a PID of a closed file descriptor doesn't raise, but returns:ok.This PR makes use of
handle_terminate_request/2and ensures that the temporary file is merged before sink gracefully terminates. Since the file descriptors close themselves when the element that opened them terminates, I've replaced the resource guard with the callback implementation in other elements, too (their resource guards just tried to close already closed files anyway).Also, updated CI config so we have Hex releases on tag push and bumped the patch version of the package.