Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: VoyageAI embeddings integration #2111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Adversarian
Copy link

Description

This PR integrates VoyageAI's embedding models for use with mem0.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2024

CLA assistant check
All committers have signed the CLA.

@Adversarian
Copy link
Author

@Dev-Khant I'm sorry for the ping, I noticed the latest couple of PRs were merged by you so I assumed you're the designated reviewer. I was wondering if I could get a review on this? We're using VoyageAI embeddings internally and I'd like to know if there's a problem with this PR that I can fix or not. I'd appreciate it if you'd let me know.

@Dev-Khant
Copy link
Member

Hi @Adversarian,

Sure, I’d review the PR. Before diving in, can I kindly ask how this integration is beneficial for you? You mentioned using it internally, and we would like to understand the use case you’re applying it to.

@Adversarian
Copy link
Author

Adversarian commented Jan 4, 2025

Hi @Adversarian,

Sure, I’d review the PR. Before diving in, can I kindly ask how this integration is beneficial for you? You mentioned using it internally, and we would like to understand the use case you’re applying it to.

Of course @Dev-Khant ! Thank you for taking the time. As I said, our embedding provider (VoyageAI) is not listed in any of your the providers that you currently support, this simply extends the list of embedders with another well-known provider so that me and people who would like to use VoyageAI as their embedding provider can use their services in tandem with mem0.

If you don't think this is a valid use-case I would appreciate hearing your thoughts as to why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants