-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin edk to v0.1.0 #8
Conversation
@edgarrmondragon @WillDaSilva any idea why this test is failing? It says models doesnt exist but looks like it does https://github.com/meltano/edk/blob/main/meltano/edk/models.py. |
@pnadolny13 I'll update mypy 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnadolny13 Had to fix the import and EDK usage. This is g2g now, I think but I'd test it before 😅
@edgarrmondragon I actually cant get this working 🤔 although I'm not sure its related to this PR specifically, looking into it more |
@pnadolny13 Any luck figuring out those failures? |
@edgarrmondragon I havent had time to try again but when I tried last week I was getting failures going through the hub getting started steps when pointing to main so I didnt have a base case to tests this branch against. |
@edgarrmondragon I confirmed this is good! I also found some bugs related to it and fixed them in meltano/hub#1169. |
Related to meltano/hub#1115