Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target cookie cutter SQL option doesn't use SQL #815

Closed
visch opened this issue Jul 14, 2022 · 2 comments · Fixed by #816
Closed

target cookie cutter SQL option doesn't use SQL #815

visch opened this issue Jul 14, 2022 · 2 comments · Fixed by #816
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@visch
Copy link
Contributor

visch commented Jul 14, 2022

  1. cookiecutter https://github.com/meltano/sdk --directory="cookiecutter/target-template"
  2. cat sinks.py
# sinks.py
"""testermctestface target sink class, which handles writing streams."""


from singer_sdk.sinks import RecordSink


class testermctestfaceSink(RecordSink):
    """testermctestface target sink class."""

    def process_record(self, record: dict, context: dict) -> None:
        """Process the record."""
        # Sample:
        # ------
        # client.write(record)
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Jul 14, 2022

thanks for reporting @visch!

There was a similar issue (I think) in the tap template: #650

@edgarrmondragon
Copy link
Collaborator

@visch I went ahead and created #816 since this seems rather critical for folks to start building more targets with the SDK. Let me know if you think it's missing something 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants