Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cookiecutter template for non rest graphql client.py to evaluate equals other - [merged] #650

Closed
MeltyBot opened this issue Apr 22, 2022 · 0 comments

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented Apr 22, 2022

Merges 354-cookiecutter-client-file-logic-overwrite-fix -> main

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/276


Closes #354

To stop the SQL client.py file from being overwritten during initialization I propose changing the client.py evaluation for not in REST or GraphQL from:

{%if cookiecutter.stream_type not in ('REST', 'GraphQL')%}client.py{%endif%}

to the following:

{%if 'Other' == cookiecutter.stream_type %}client.py{%endif%}

My reasoning is that there are 4 streams types REST, GraphQL, SQL, and Other. REST, GraphQL and SQL all have designated client.py files which leaves only a stream type of Other without a designated client.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant