Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: SQLTarget Invalid Schema should fail nicely #1145

Closed
visch opened this issue Nov 5, 2022 · 0 comments · Fixed by #1287
Closed

[Feature]: SQLTarget Invalid Schema should fail nicely #1145

visch opened this issue Nov 5, 2022 · 0 comments · Fixed by #1287
Labels
kind/Feature New feature or request valuestream/SDK
Milestone
SQL Target Out-of...

Comments

@visch
Copy link
Contributor

visch commented Nov 5, 2022

Feature scope

Targets (data type handling, batching, SQL object generation, etc.)

Description

Should go on SQL Target milestone

https://github.com/MeltanoLabs/target-postgres/blob/main/target_postgres/tests/test_standard_target.py#L70 is the test_invalid_schema test.

We should fail nicely, this test was taken from https://github.com/MeltanoLabs/target-sqlite/blob/master/tests/test_target_sqlite.py#L34-L42

We should probably do the validation in the SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/Feature New feature or request valuestream/SDK
Projects
None yet
Milestone
SQL Target Out-of-Box Stability
2 participants
@visch @aaronsteers