Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for incorrect snapToItem #648

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix for incorrect snapToItem #648

merged 1 commit into from
Apr 3, 2020

Conversation

sergeyzhukov
Copy link
Contributor

@sergeyzhukov sergeyzhukov commented Feb 9, 2020 •
edited
Loading

Platforms affected

iOS, Android

What does this PR do?

Fixed snapToItem not working correctly.

What testing has been done on this change?

Tested on iOS / Android

Tested features checklist

bfaulk96
bfaulk96 approved these changes Feb 10, 2020
View reviewed changes
Copy link

@bfaulk96 bfaulk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the snapToNext() and snapToPrev() for both Android and iOS, mentioned in issue #552

@bfaulk96 bfaulk96 mentioned this pull request Feb 10, 2020
Open
5 tasks
@Romick2005
Copy link

Does my resolution here Romick2005@972dadf fixes the issues for you?

@bd-arc bd-arc merged commit 5da199a into meliorence:master Apr 3, 2020
@bd-arc bd-arc mentioned this pull request Apr 3, 2020
Closed
11 tasks
@thanh94r10
Copy link

thanks, this works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfaulk96 bfaulk96 bfaulk96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergeyzhukov @Romick2005 @thanh94r10 @ahce @bfaulk96 @bd-arc