You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just wanted to say thanks for the great library, we're really impressed with the performance of it vs using a WebView!
We've noticed that, at the moment, tagsStyles override classesStyles - e.g. with the following code, the last-paragraph will come out grey rather than teal, because the styling for 'p' tag is applied after the "last-paragraph" class styling:
// props
tagsStyles: {p: {color: 'grey'}},classesStyles: {'last-paragraph': {color: 'teal'}}consthtml=` <p class="last-paragraph">Finally, this paragraph is style through the classesStyles prop</p>`;
We think it would make more sense to swap this round to be more similar to CSS Specificity, where class selectors take precedence over type selectors. What do you think?
I think it might be as simple as just swapping over lines 324 and 325 in HTML.js
Let me know if you approve of this change and I can submit a PR for it. I just wanted to check whether you agree with the idea of the change first!
The text was updated successfully, but these errors were encountered:
Just wanted to say thanks for the great library, we're really impressed with the performance of it vs using a WebView!
We've noticed that, at the moment, tagsStyles override classesStyles - e.g. with the following code, the last-paragraph will come out grey rather than teal, because the styling for 'p' tag is applied after the "last-paragraph" class styling:
We think it would make more sense to swap this round to be more similar to CSS Specificity, where class selectors take precedence over type selectors. What do you think?
I think it might be as simple as just swapping over lines 324 and 325 in HTML.js
Let me know if you approve of this change and I can submit a PR for it. I just wanted to check whether you agree with the idea of the change first!
The text was updated successfully, but these errors were encountered: