img's tag resizeMode property not modifiable through html tagStyles #172

adderly · 2018-08-03T20:00:38Z

Is this a bug report or a feature request?

feature/bug

Details

There seems no way to set the resizeMode property to an image tag through the tagStyles.

const myTagStyles = {
    img: {
        resizeMode: 'contain',
    },
};
<HTML  tagsStyles={myTagStyles} />

As i searched in the source code it defaults to "cover".

adderly · 2018-08-10T20:03:28Z

I made a little PR addressing the issue.
I added some thing that might not be needed, you guys check it out.

Exilz · 2019-02-08T17:02:04Z

If someone needs this feature and is reading this issue, this still needs to be addressed.

This should be a fairly easy change. So, if you're wiling to contribute to this project, this is a good starting point.

adderly · 2019-02-11T14:28:10Z

Well, i made some changes to a branch but it is nothing pull request worthy...

wxcvbn612 · 2019-04-25T19:31:30Z

why you put cover as default, make stretch or contain?
im make resizeMode in img but not make effect, can you help me with that ?

aashish-pixere · 2020-04-20T13:45:59Z

Is there any solution for this ?

LorrisSaintGenez · 2020-06-07T13:46:33Z

@Exilz Any blocking to this PR #315 ? That would hopefully solve this issue. Will need to fork it in the meantime, but would rather avoid it

jsamr · 2020-07-05T10:28:28Z

@LorrisSaintGenez We're working on it!

BREAKING: imagesMaxWidth prop is discontinued in favor of contentWidth and computeImagesMaxWidth. See RFC001 for an exhaustive description. This patch offers a rewrite of the HTMLImage component to get a close match with RFC001, “a deterministic approach to images scaling”. The only part of this RFC which is unsupported is the unitConverter behavior, which is planned for a later major release. In addition to the capabilities defined in the RFC, this patch provides the new property enableExperimentalPercentWidth. It allows percent width for <img> tags, computed relatively to contentWidth. This patch also fixes #141, #172 and provides the features offered in PR #242 and #315. fixes #141 fixes #172 closes #315 closes #242

BREAKING: imagesMaxWidth prop is discontinued in favor of contentWidth and computeImagesMaxWidth. See RFC001 for an exhaustive description. This patch offers a rewrite of the HTMLImage component to get a close match with RFC001, “a deterministic approach to images scaling”. The only part of this RFC which is unsupported is the unitConverter behavior, which is planned for a later major release. In addition to the capabilities defined in the RFC, this patch provides the following features and behaviors: - new property enableExperimentalPercentWidth. It allows percent width for <img> tags, computed relatively to contentWidth. - take margins into account when scaling down images; - support for overriding image styles, including resizeMode; - support for minWidth, minHeight, maxWidth, maxHeight styles. This patch also fixes #141, #172 and provides the features offered in PR #242 and #315. fixes #141 fixes #172 closes #315 closes #242

BREAKING: imagesMaxWidth prop is discontinued in favor of contentWidth and computeImagesMaxWidth. See RFC001 for an exhaustive description. This patch offers a rewrite of the HTMLImage component to get a close match with RFC001, “a deterministic approach to images scaling”. The only part of this RFC which is unsupported is the unitConverter behavior, which is planned for a later major release. In addition to the capabilities defined in the RFC, this patch provides the following features and behaviors: - new property enableExperimentalPercentWidth. It allows percent width for <img> tags, computed relatively to contentWidth. - take margins into account when scaling down images; - support for overriding image styles, including resizeMode; - support for minWidth, minHeight, maxWidth, maxHeight styles. This patch also fixes #141, #172 and provides the features offered in PR #242 and #315. OPTIMIZATIONS: The imageBoxDimensions are computed when required. In addition, requirements are also recomputed when necessary, preventing expensive operations from happening too often. Also, because we need to flatten the style prop to infer requirements, this flatten value is now cached and re-evaluated when appropriate. Finally, styles have been moved to a stylesheet when that is possible, to avoid commiting updates to the native side. Note that these performance optimizations are made possible by the high coverage rate of the HTMLImage component. fixes #141 fixes #172 closes #315 closes #242

BREAKING: imagesMaxWidth prop is discontinued in favor of contentWidth and computeImagesMaxWidth. See RFC001 for an exhaustive description. This patch offers a rewrite of the HTMLImage component to get a close match with RFC001, “a deterministic approach to images scaling”. The only part of this RFC which is unsupported is the unitConverter behavior, which is planned for a later major release. In addition to the capabilities defined in the RFC, this patch provides the following features and behaviors: - new property enableExperimentalPercentWidth. It allows percent width for <img> tags, computed relatively to contentWidth. - take margins into account when scaling down images; - support for overriding image styles, including resizeMode; - support for minWidth, minHeight, maxWidth, maxHeight styles. This patch also fixes #141, #172 and provides the features offered in PR #242 and #315. OPTIMIZATIONS: The imageBoxDimensions are computed when required. In addition, requirements are also recomputed when necessary, preventing expensive operations from happening too often. Also, because we need to flatten the style prop to infer requirements, this flatten value is now cached and re-evaluated when appropriate. Finally, styles have been moved to a stylesheet when that is possible, to avoid commiting updates to the native side. Note that these performance optimizations are made possible by the high coverage rate of the HTMLImage component. fixes #141 fixes #172 updates #412 (could fix) closes #315 closes #242

Exilz added the new feature label Feb 8, 2019

adderly closed this as completed Feb 11, 2019

adderly reopened this Feb 11, 2019

jsamr mentioned this issue Jul 5, 2020

Override Image resizeMode ? #269

Closed

jsamr linked a pull request Jul 5, 2020 that will close this issue

fix image styles override #315

Closed

jsamr added the is:waiting pr A pull request is awaiting reviews to solve the problem. label Jul 5, 2020

jsamr added a commit that referenced this issue Jul 24, 2020

tests: provide regression against #172, ignored resize-mode

43ac44f

jsamr mentioned this issue Jul 24, 2020

A revamped scalable HTMLImage component #389

Merged

2 tasks

jsamr linked a pull request Jul 24, 2020 that will close this issue

A revamped scalable HTMLImage component #389

Merged

2 tasks

jsamr added a commit that referenced this issue Jul 24, 2020

tests: provide regression against #172, ignored resize-mode

0b60e3a

jsamr added a commit that referenced this issue Jul 24, 2020

tests: provide regression against #172, ignored resize-mode

ced2ef2

jsamr added a commit that referenced this issue Jul 24, 2020

tests: provide regression against #172, ignored resize-mode

5c733e2

jsamr added a commit that referenced this issue Jul 27, 2020

tests: provide regression against #172, ignored resize-mode

1f98055

jsamr added a commit that referenced this issue Jul 27, 2020

tests: provide regression against #172, ignored resize-mode

53d2928

jsamr added a commit that referenced this issue Sep 26, 2020

tests: provide regression against #172, ignored resize-mode

4ca0312

jsamr closed this as completed in #389 Sep 26, 2020

jsamr added a commit that referenced this issue Sep 26, 2020

tests: provide regression against #172, ignored resize-mode

09d7a13

jsamr added a commit that referenced this issue Nov 30, 2020

fix: regression #172 (passing Image-specific styles to img component)

916d977

jsamr mentioned this issue Dec 5, 2020

[5.x] 🚀 A new "Legacy" Major #442

Closed

jsamr added a commit that referenced this issue Dec 10, 2020

fix: regression #172 (passing Image-specific styles to img component)

c7e3691

jsamr added a commit that referenced this issue Dec 10, 2020

test: fix regression #172 test

ce8a086

jsamr added a commit that referenced this issue Jun 4, 2021

fix: regression #172 (passing Image-specific styles to img component)

ffbbe8e

jsamr added a commit that referenced this issue Jun 4, 2021

test: fix regression #172 test

2e9573b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

img's tag resizeMode property not modifiable through html tagStyles #172

img's tag resizeMode property not modifiable through html tagStyles #172

adderly commented Aug 3, 2018 •

edited

Loading

adderly commented Aug 10, 2018

Exilz commented Feb 8, 2019

adderly commented Feb 11, 2019

wxcvbn612 commented Apr 25, 2019 •

edited

Loading

aashish-pixere commented Apr 20, 2020

LorrisSaintGenez commented Jun 7, 2020 •

edited

Loading

jsamr commented Jul 5, 2020

img's tag resizeMode property not modifiable through html tagStyles #172

img's tag resizeMode property not modifiable through html tagStyles #172

Comments

adderly commented Aug 3, 2018 • edited Loading

Is this a bug report or a feature request?

Details

adderly commented Aug 10, 2018

Exilz commented Feb 8, 2019

adderly commented Feb 11, 2019

wxcvbn612 commented Apr 25, 2019 • edited Loading

aashish-pixere commented Apr 20, 2020

LorrisSaintGenez commented Jun 7, 2020 • edited Loading

jsamr commented Jul 5, 2020

adderly commented Aug 3, 2018 •

edited

Loading

wxcvbn612 commented Apr 25, 2019 •

edited

Loading

LorrisSaintGenez commented Jun 7, 2020 •

edited

Loading