Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch to vite-multiple-assets once upstream is fixed #2330

Closed
melink14 opened this issue Dec 19, 2024 · 3 comments · Fixed by #2351
Closed

Remove patch to vite-multiple-assets once upstream is fixed #2330

melink14 opened this issue Dec 19, 2024 · 3 comments · Fixed by #2351
Labels
released

Comments

@melink14
Copy link
Owner

https://github.com/melink14/rikaikun/blob/main/patches/vite-multiple-assets%2B2.2.4.patch

We removed an extra duplicate interface so that tsc would work with no compilation errors.

@SnoozeThis nguyenbatranvan/vite-multiple-assets#40 <= 1 month
@SnoozeThis
Copy link

(https://snoozeth.is/yBCzH4tzLqg) I will wait until nguyenbatranvan/vite-multiple-assets#40 is closed and then reassign to you (until at most Sun, 19 Jan 2025 10:04:00 UTC).

@SnoozeThis
Copy link

Resolved.

melink14 added a commit that referenced this issue Dec 23, 2024
@melink14
build: Remove short term fixes for vite-multiple-assets now that the …
8c87a58 
…upstream issues are fixed

Fixes #2330
Fixes #2331
@melink14 melink14 mentioned this issue Dec 23, 2024
Merged
@mergify mergify bot closed this as completed in #2351 Dec 23, 2024
@mergify mergify bot closed this as completed in 159fe35 Dec 23, 2024
@melink14
Copy link
Owner Author

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@melink14 @SnoozeThis