Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in to Neo's config GUI #8166

Merged
merged 15 commits into from
Aug 23, 2024
Merged

Opt-in to Neo's config GUI #8166

merged 15 commits into from
Aug 23, 2024

Conversation

pupnewfster
Copy link
Member

@pupnewfster pupnewfster commented Jul 21, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Adds support for editing our configs using the config gui, and for translating their contents. Configuration is not accessible through the forge mod menu #5794
  • Restructure organization of entries within individual config files
  • Fixes Mekanism's Additions description translation not being usable
  • All configs will end up getting reset as I removed a parent level node in order to make the config gui easier to navigate.
  • Flip Mekanism Addition's voice key is toggle config to a push to talk config option. (Same default behavior, just is a bit better of a name)
  • Slightly lowered the default dumpExcessKeepRatio config value (from 0.9 to 0.85)

@pupnewfster pupnewfster modified the milestones: 10.6.7, 10.6.8 Jul 21, 2024
@pupnewfster pupnewfster marked this pull request as ready for review August 23, 2024 03:02
@pupnewfster pupnewfster modified the milestones: 10.7.3, 10.7.5 Aug 23, 2024
@pupnewfster pupnewfster merged commit a11d886 into 1.21.x Aug 23, 2024
2 checks passed
@pupnewfster pupnewfster deleted the feature_config_gui branch August 23, 2024 21:33
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 23, 2024
View reviewed changes
src/main/java/mekanism/common/config/MekanismConfigTranslations.java
Comment on lines +43 to +44
"If true, renders sides for Universal Cables, Mechanical Pipes, Pressurized Tubes, Logistical Transporters, and Thermodynamic Conductors instead of"
+ "rendering their contents. If transmitters are causing you fps issues, this should hopefully help."),

Check notice

Code scanning / CodeQL

Missing space in string literal Note

This string appears to be missing a space after 'of'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.21 enhancement feature moderateimportance Usability
Projects
None yet
Milestone
10.7.5
Development

Successfully merging this pull request may close these issues.
1 participant
@pupnewfster