add constant for array creation

mekanism · Jul 14, 2024 · e7dde77 · e7dde77
1 parent cba0bec
commit e7dde77
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/src/generators/java/mekanism/generators/common/tile/TileEntityAdvancedSolarGenerator.java b/src/generators/java/mekanism/generators/common/tile/TileEntityAdvancedSolarGenerator.java
@@ -15,6 +15,7 @@
 
 public class TileEntityAdvancedSolarGenerator extends TileEntitySolarGenerator implements IBoundingBlock, IEvaporationSolar {
 
+    private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT, RelativeSide.BOTTOM};
     private final SolarCheck[] solarChecks = new SolarCheck[8];
 
     public TileEntityAdvancedSolarGenerator(BlockPos pos, BlockState state) {
@@ -23,7 +24,7 @@ public TileEntityAdvancedSolarGenerator(BlockPos pos, BlockState state) {
 
     @Override
     protected RelativeSide[] getEnergySides() {
-        return new RelativeSide[]{RelativeSide.FRONT, RelativeSide.BOTTOM};
+        return ENERGY_SIDES;
     }
 
     @Override

diff --git a/src/generators/java/mekanism/generators/common/tile/TileEntityGenerator.java b/src/generators/java/mekanism/generators/common/tile/TileEntityGenerator.java
@@ -26,6 +26,8 @@
 
 public abstract class TileEntityGenerator extends TileEntityMekanism {
 
+    private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT};
+
     @Nullable
     private List<BlockEnergyCapabilityCache> outputCaches;
     /**
@@ -43,7 +45,7 @@ public TileEntityGenerator(IBlockProvider blockProvider, BlockPos pos, BlockStat
     }
 
     protected RelativeSide[] getEnergySides() {
-        return new RelativeSide[]{RelativeSide.FRONT};
+        return ENERGY_SIDES;
     }
 
     @NotNull
@@ -63,7 +65,7 @@ protected boolean onUpdateServer() {
                 Direction direction = getDirection();
                 RelativeSide[] energySides = getEnergySides();
                 outputCaches = new ArrayList<>(energySides.length);
-                for (RelativeSide energySide : getEnergySides()) {
+                for (RelativeSide energySide : energySides) {
                     Direction side = energySide.getDirection(direction);
                     outputCaches.add(BlockEnergyCapabilityCache.create((ServerLevel) level, worldPosition.relative(side), side.getOpposite()));
                 }

diff --git a/src/generators/java/mekanism/generators/common/tile/TileEntitySolarGenerator.java b/src/generators/java/mekanism/generators/common/tile/TileEntitySolarGenerator.java
@@ -29,6 +29,7 @@
 
 public class TileEntitySolarGenerator extends TileEntityGenerator {
 
+    private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.BOTTOM};
     private boolean seesSun;
     private FloatingLong lastProductionAmount = FloatingLong.ZERO;
     @WrappingComputerMethod(wrapper = ComputerIInventorySlotWrapper.class, methodNames = "getEnergyItem", docPlaceholder = "energy item slot")
@@ -114,7 +115,7 @@ protected float getBrightnessMultiplier(@NotNull Level world) {
 
     @Override
     protected RelativeSide[] getEnergySides() {
-        return new RelativeSide[]{RelativeSide.BOTTOM};
+        return ENERGY_SIDES;
     }
 
     protected FloatingLong getConfiguredMax() {

diff --git a/src/generators/java/mekanism/generators/common/tile/TileEntityWindGenerator.java b/src/generators/java/mekanism/generators/common/tile/TileEntityWindGenerator.java
@@ -27,6 +27,7 @@
 public class TileEntityWindGenerator extends TileEntityGenerator implements IBoundingBlock {
 
     private static final float SPEED = 32F;
+    private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT, RelativeSide.BOTTOM};
 
     private double angle;
     private FloatingLong currentMultiplier = FloatingLong.ZERO;
@@ -48,7 +49,7 @@ protected IInventorySlotHolder getInitialInventory(IContentsListener listener) {
 
     @Override
     protected RelativeSide[] getEnergySides() {
-        return new RelativeSide[]{RelativeSide.FRONT, RelativeSide.BOTTOM};
+        return ENERGY_SIDES;
     }
 
     @Override