This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Make facetsDistribution name iso #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I have the renaming of this field in the product backlog. So let's stay ISO to avoid two breaking changes! :) It should be named facetsDistribution to stay iso with v0.20! It seems to be named |
curquiza
force-pushed
the
fix-facets-distribution
branch
from
fd624f1 to
6d24a47
Compare
MarinPostma
approved these changes
Jun 23, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if there is an English mistake in
facets_distribution(because of thes) @gmourier asked me to keep the typo: the name offacetsDistributionmight change completely in the future, he wants to avoid two breakings.@gmourier can you confirm before we merge this PR?
Sorry I left this update in the code (I'm confused because no issues was open to update
facetsDistribution), there might have been a confusion withfieldsDistributionthat has been renamed intofieldDistribution. Sorry!