Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Add a github action to run cargo-flaky 1000 times #202

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Jun 10, 2021

I don’t know how to ensure the CI works so it’s just a first version, do not hesitate to update the code

@irevoire irevoire requested a review from curquiza June 10, 2021 14:55
.github/workflows/flaky.yml Outdated Show resolved Hide resolved
.github/workflows/flaky.yml Outdated Show resolved Hide resolved
.github/workflows/flaky.yml Outdated Show resolved Hide resolved
.github/workflows/flaky.yml Outdated Show resolved Hide resolved
.github/workflows/flaky.yml Outdated Show resolved Hide resolved
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@irevoire irevoire requested review from curquiza and MarinPostma June 10, 2021 15:02
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@irevoire
Copy link
Member Author

@MarinPostma since you wrote the tool I added you as a reviewer so you can add some args to cargo-flaky.
Also we should implement this issue meilisearch/cargo-flaky#7

@irevoire
Copy link
Member Author

If you are ok with the PR we can merge 😄

@irevoire irevoire requested a review from curquiza June 10, 2021 16:29
Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bors merge

bors bot added a commit that referenced this pull request Jun 10, 2021
202: Add a github action to run cargo-flaky 1000 times r=MarinPostma a=irevoire

I don’t know how to ensure the CI works so it’s just a first version, do not hesitate to update the code

Co-authored-by: Irevoire <tamo@meilisearch.com>
@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 10, 2021

@bors bors bot merged commit d46a271 into main Jun 10, 2021
@bors bors bot deleted the ci/cargo-flaky branch June 10, 2021 22:25
@Kerollmops
Copy link
Member

Quick question: How would you be informed if the test fail?

@curquiza
Copy link
Member

If I understand well how GH works, it depends on:

  • if you watch the repo
  • how you set your notification settings:

Capture d’écran 2021-06-14 à 09 39 15

In my case, I hope I will receive a GH notification :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants